Disallow abstract member with access modifiers in sig file by ijklam · Pull Request #17802 · dotnet/fsharp

ijklam · 2024-09-26T18:09:52Z

Description

Disallow abstract member with access modifiers in signature files.

// in a .fsi file
type A =
    abstract internal B: int ->int
    abstract member C: int with internal get, private set

Before: All these will build successfully
After: Error FS0561: Accessibility modifiers are not allowed on this member. Abstract slots always have the same visibility as the enclosing type.

Checklist

Test cases added

github-actions · 2024-09-26T18:10:35Z

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description

src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

KevinRansom · 2024-09-26T19:00:02Z

@Tangent-90 -
Hey, I was wondering why would an internal abstract member not be allowed on a public type? After all the assembly where it is defined, as well as friend assemblies can still implement it?

ijklam · 2024-09-27T00:57:23Z

@Tangent-90 -
Hey, I was wondering why would an internal abstract member not be allowed on a public type? After all the assembly where it is defined, as well as friend assemblies can still implement it?

Hmm... I just simply find out that abstract internal in .fs file is not allowed, and in .fsi file will take no effect.

ijklam · 2024-09-30T11:10:51Z

error when running Plain_Build_MacOS/Regular rebuild of FSharp.Compiler.Service.sln

Unhandled exception. System.BadImageFormatException: Bad IL format. The format of the file '/Users/runner/work/1/s/artifacts/bin/fsyacc/Debug/net9.0/osx-x64/fsyacc.dll' is invalid.
/var/folders/t5/14gs56bj7djcylkj26c908n40000gn/T/MSBuildTemprunner/tmpb55944d209f44f83b58b156af720d99b.exec.cmd: line 2: 4313 Abort trap: 6 "/Users/runner/hostedtoolcache/dotnet/dotnet" "/Users/runner/work/1/s/artifacts//bin/fsyacc/Debug/net9.0/osx-x64/fsyacc.dll" -o "/Users/runner/work/1/s/artifacts/obj/FSharp.Compiler.Service/Debug/net9.0/ilpars.fs" --module FSharp.Compiler.AbstractIL.AsciiParser --open FSharp.Compiler.AbstractIL.AsciiConstants --open FSharp.Compiler.AbstractIL.IL --internal --lexlib Internal.Utilities.Text.Lexing --parslib Internal.Utilities.Text.Parsing --buffer-type-argument char AbstractIL/ilpars.fsy
/Users/runner/work/1/s/buildtools/buildtools.targets(54,5): error MSB3073: The command ""/Users/runner/hostedtoolcache/dotnet/dotnet" "/Users/runner/work/1/s/artifacts//bin/fsyacc/Debug/net9.0/osx-x64/fsyacc.dll" -o "/Users/runner/work/1/s/artifacts/obj/FSharp.Compiler.Service/Debug/net9.0/ilpars.fs" --module FSharp.Compiler.AbstractIL.AsciiParser --open FSharp.Compiler.AbstractIL.AsciiConstants --open FSharp.Compiler.AbstractIL.IL --internal --lexlib Internal.Utilities.Text.Lexing --parslib Internal.Utilities.Text.Parsing --buffer-type-argument char AbstractIL/ilpars.fsy" exited with code 134. [/Users/runner/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=net9.0]

github-actions · 2024-09-30T11:11:00Z

Failed to run : https://github.com/dotnet/fsharp/actions/runs/11104909529

edgarfgp · 2024-10-08T21:15:55Z

error when running Plain_Build_MacOS/Regular rebuild of FSharp.Compiler.Service.sln

Unhandled exception. System.BadImageFormatException: Bad IL format. The format of the file '/Users/runner/work/1/s/artifacts/bin/fsyacc/Debug/net9.0/osx-x64/fsyacc.dll' is invalid.
/var/folders/t5/14gs56bj7djcylkj26c908n40000gn/T/MSBuildTemprunner/tmpb55944d209f44f83b58b156af720d99b.exec.cmd: line 2: 4313 Abort trap: 6 "/Users/runner/hostedtoolcache/dotnet/dotnet" "/Users/runner/work/1/s/artifacts//bin/fsyacc/Debug/net9.0/osx-x64/fsyacc.dll" -o "/Users/runner/work/1/s/artifacts/obj/FSharp.Compiler.Service/Debug/net9.0/ilpars.fs" --module FSharp.Compiler.AbstractIL.AsciiParser --open FSharp.Compiler.AbstractIL.AsciiConstants --open FSharp.Compiler.AbstractIL.IL --internal --lexlib Internal.Utilities.Text.Lexing --parslib Internal.Utilities.Text.Parsing --buffer-type-argument char AbstractIL/ilpars.fsy
/Users/runner/work/1/s/buildtools/buildtools.targets(54,5): error MSB3073: The command ""/Users/runner/hostedtoolcache/dotnet/dotnet" "/Users/runner/work/1/s/artifacts//bin/fsyacc/Debug/net9.0/osx-x64/fsyacc.dll" -o "/Users/runner/work/1/s/artifacts/obj/FSharp.Compiler.Service/Debug/net9.0/ilpars.fs" --module FSharp.Compiler.AbstractIL.AsciiParser --open FSharp.Compiler.AbstractIL.AsciiConstants --open FSharp.Compiler.AbstractIL.IL --internal --lexlib Internal.Utilities.Text.Lexing --parslib Internal.Utilities.Text.Parsing --buffer-type-argument char AbstractIL/ilpars.fsy" exited with code 134. [/Users/runner/work/1/s/src/Compiler/FSharp.Compiler.Service.fsproj::TargetFramework=net9.0]

Seen this in the past. Had to close and reopen my PR multiple times until the CI is green.

github-actions · 2024-10-08T21:16:04Z

Failed to run : https://github.com/dotnet/fsharp/actions/runs/11243858547

src/Compiler/pars.fsy

...mance/BasicGrammarElements/AccessibilityAnnotations/PermittedLocations/PermittedLocations.fs

edgarfgp

Thanks for this. It improves by a mile the access modifiers error reporting in sig file.

psfinaki · 2024-10-14T15:08:24Z

/azp run

azure-pipelines · 2024-10-14T15:08:42Z

Azure Pipelines successfully started running 2 pipeline(s).

...mance/BasicGrammarElements/AccessibilityAnnotations/PermittedLocations/PermittedLocations.fs

psfinaki

Alright then, let's get this in - thanks!

Disallow abstract member with access modifiers in sig file

f11d08f

ijklam requested a review from a team as a code owner September 26, 2024 18:09

ijklam added 2 commits September 27, 2024 02:12

release note

115444c

Merge branch 'main' into fix-abstract-accessor-sig-file

83037d5

ijklam added 5 commits September 27, 2024 21:19

Merge branch 'main' into fix-abstract-accessor-sig-file

defb342

format

348011e

fix

da7d50a

fix test

f64c4fe

Merge branch 'main' into fix-abstract-accessor-sig-file

22db16d

Merge branch 'main' into fix-abstract-accessor-sig-file

659375c

edgarfgp reviewed Oct 9, 2024

View reviewed changes

src/Compiler/pars.fsy Outdated Show resolved Hide resolved

ijklam added 2 commits October 9, 2024 23:25

use access modifier range to show error

382bed2

Merge branch 'main' into fix-abstract-accessor-sig-file

b5b5786

edgarfgp reviewed Oct 9, 2024

View reviewed changes

...mance/BasicGrammarElements/AccessibilityAnnotations/PermittedLocations/PermittedLocations.fs Outdated Show resolved Hide resolved

ijklam added 2 commits October 10, 2024 12:52

update tests

45d54a2

update tests

8a77bb3

edgarfgp approved these changes Oct 10, 2024

View reviewed changes

Merge branch 'main' into fix-abstract-accessor-sig-file

710bdd8

T-Gro approved these changes Oct 23, 2024

View reviewed changes

psfinaki reviewed Oct 23, 2024

View reviewed changes

...mance/BasicGrammarElements/AccessibilityAnnotations/PermittedLocations/PermittedLocations.fs Show resolved Hide resolved

Merge branch 'main' into fix-abstract-accessor-sig-file

b28ba93

KevinRansom approved these changes Oct 23, 2024

View reviewed changes

Merge branch 'main' into fix-abstract-accessor-sig-file

f4f128e

KevinRansom enabled auto-merge October 23, 2024 22:34

show both FS0531 and FS0561

88e49a9

auto-merge was automatically disabled October 24, 2024 01:47
Head branch was pushed to by a user without write access

psfinaki approved these changes Oct 24, 2024

View reviewed changes

psfinaki merged commit 8b0900c into dotnet:main Oct 24, 2024

This was referenced Oct 31, 2024

[Automated] PRs inserted in VS build main-35430.72 #17943

Closed

[Automated] PRs inserted in VS build feature.debugger.main-35430.275 #17944

Closed

dotnet-bot mentioned this pull request Nov 19, 2024

[Automated] PRs inserted in VS build feature.debugger.shadowDebug-35518.109 #18027

Closed

Martin521 mentioned this pull request Jun 3, 2025

Adaptation to breaking FCS changes in sdk 9.0 and 10.0 fsprojects/fantomas#3167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow abstract member with access modifiers in sig file#17802

Disallow abstract member with access modifiers in sig file#17802
psfinaki merged 17 commits intodotnet:mainfrom
ijklam:fix-abstract-accessor-sig-file

ijklam commented Sep 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 26, 2024 •

edited

Loading

Uh oh!

KevinRansom commented Sep 26, 2024

Uh oh!

ijklam commented Sep 27, 2024

Uh oh!

ijklam commented Sep 30, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

edgarfgp commented Oct 8, 2024

Uh oh!

github-actions bot commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

edgarfgp left a comment

Uh oh!

psfinaki commented Oct 14, 2024

Uh oh!

azure-pipelines bot commented Oct 14, 2024

Uh oh!

Uh oh!

psfinaki left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ijklam commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

github-actions bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❗ Release notes required

Uh oh!

KevinRansom commented Sep 26, 2024

Uh oh!

ijklam commented Sep 27, 2024

Uh oh!

ijklam commented Sep 30, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

edgarfgp commented Oct 8, 2024

Uh oh!

github-actions bot commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

edgarfgp left a comment

Choose a reason for hiding this comment

Uh oh!

psfinaki commented Oct 14, 2024

Uh oh!

azure-pipelines bot commented Oct 14, 2024

Uh oh!

Uh oh!

psfinaki left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ijklam commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading